Uploaded image for project: 'Stripes'
  1. STS-785

Add "event" for subclasses of OnwardResolution

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects versions: Release 1.5.4
    • Fix versions: Release 1.5.7, Release 1.6
    • Components: None
    • Labels:
      None
    • Sprint:

      Description

      When attempting to create things like LocalizedRedirectResolution one subclasses RedirectResolution

      However in: net.sourceforge.stripes.action.OnwardResolution
      We have:
      private static final String VALUE_NOT_SET = "VALUE_NOT_SET";
      private String path;
      private String event = VALUE_NOT_SET;
      private Map<String,Object> parameters = new HashMap<String,Object>();
      private String anchor;

      Problem #1:
      ----------------
      path, anchor, and parameters have public getters/setters however 'event' attribute does not?

      REQUEST: Please add public getters/setters for event
      NOTE: One could make the above things protected to be accessible in subclasses but I suggest public as it is in-line with how the rest of the class is written.

      Problem #2:
      ----------------
      Having public access to to 'event' is great but one needs to be able to compare to see if the value is not set however the following is private:
      private static final String VALUE_NOT_SET = "VALUE_NOT_SET";

      REQUEST: Please make the above static at least protected vs. private so as to be able to compare within subclasses.

      This is a really trivial request that makes the class more consistent.

      --Nikolaos

        Attachments

          Activity

            People

            • Assignee:
              bengunter BenB
              Reporter:
              nikolaos nikolaos
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: