We're updating the issue view to help you get more done. 

Meaningful error message when an "on" in @Validate annotation is an empty String

Description

If a property has an annotation @Validate(on="") this is an error. I accidentally did just this in my project and it took me some time to figure out where the weird exception was coming from.

I propose to add a more meaningful error message for example with the help of the following patch:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 ### Eclipse Workspace Patch 1.0 #P stripes Index: stripes/src/net/sourceforge/stripes/validation/ValidationMetadata.java =================================================================== --- stripes/src/net/sourceforge/stripes/validation/ValidationMetadata.java (revision 1487) +++ stripes/src/net/sourceforge/stripes/validation/ValidationMetadata.java (working copy) @@ -205,9 +205,13 @@ this.on = null; } else { + if (on[0].isEmpty()) + throw new IllegalArgumentException("the on property of a @Validate annotation must not be an empty string"); this.on = new HashSet<String>(); this.onIsPositive = !(on[0].charAt(0) == '!'); for (String s : on) { + if (s.isEmpty()) + throw new IllegalArgumentException("the on property of a @Validate annotation must not be an empty string"); if (this.onIsPositive) { this.on.add(s); }

Environment

None

Status

Assignee

BenB

Reporter

Yannik Hampe

Labels

None

Tester

None

Components

Fix versions

Affects versions

Release 1.5.6

Priority

Minor